Open Closed

Changing language on login page does not work anymore #1475


User avatar
0
christophe.baille created

ABP Framework version: v4.3.2 UI type: Angular DB provider: EF Core Tiered (MVC) or Identity Server Separated (Angular): no

After clicking on the login button, I reach the login page. From here, if I try to change the language, nothing happens. Language does not change, the flag neither.

It might be related to this issue fixed few weeks ago maybe.


20 Answer(s)
  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    hi

    I think there are culture&ui-culture parameters in the current URL.

    It similar to QueryStringRequestCultureProvider, It takes precedence over cookies.

    https://docs.microsoft.com/en-us/aspnet/core/fundamentals/localization?view=aspnetcore-5.0#querystringrequestcultureprovider-2

  • User Avatar
    0
    christophe.baille created

    Hi,

    Thanks for the information and sorry for the late reply. You are right, we have parameters on the current Url:

    https://localhost:44348/Account/Login?ReturnUrl=%2Fconnect%2Fauthorize%2Fcallback%3Fresponse_type%3Dcode%26client_id%3DMy_App%26state%3DbDd5SnMtVTJ5QjgzLnQxalI4UjdUR3BuS3pyWVBTemdUN3l-Tk9hUV9ZRHhJ%26redirect_uri%3Dhttp%253A%252F%252Flocalhost%253A4200%26scope%3Dopenid%2520offline_access%2520StaffApp%26code_challenge%3DkNK2i41ugtSH4I-1cdtMMk3-KvC3-x8yhLou3dkJRnM%26code_challenge_method%3DS256%26nonce%3DbDd5SnMtVTJ5QjgzLnQxalI4UjdUR3BuS3pyWVBTemdUN3l-Tk9hUV9ZRHhJ%26culture%3Den%26ui-culture%3Den

    As we can not change it from UI, should you not disable the language dropdown list on this views?

    I could eventually add this views (login, register, forgot password) on my project and edit them. But if you do changes on the future on them, i will not get the updates

    Thanks

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    hi
    We have a PR to fix this. https://github.com/abpframework/abp/pull/9545

  • User Avatar
    0
    christophe.baille created

    Great, from what I see it will be available on the version 4.4 right?

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    HI

    Yes, It's available on 4.4 final

  • User Avatar
    0
    christophe.baille created

    I just updated to the version 4.4 but it still exactly the same, it doesn't work

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    hi christophe

    Have you tried this in brand new 4.4 project?

  • User Avatar
    0
    christophe.baille created

    No,

    I am trying on the project I am developing on, but it should work after updating no?

  • User Avatar
    0
    christophe.baille created

    I just tried with a new solution 4.4, the issue is still here

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    hi

    Can you share the steps that you tried? Thanks

  • User Avatar
    0
    christophe.baille created

    1- run the application

    2- Click login button

    3- Change language, nothing happens

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    hi

    I reproduced the problem, Checking..

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    hi

    Add below code to your IDS project.

    [Dependency(ReplaceServices = true)]
    [ExposeServices(typeof(IQueryStringCultureReplacement))]
    public class MyIdentityServerReturnUrlQueryStringCultureReplacementProvider : IdentityServerReturnUrlQueryStringCultureReplacementProvider
    {
    
    }
    
  • User Avatar
    0
    christophe.baille created

    IDS project?

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    HttpApi.Host

  • User Avatar
    0
    christophe.baille created

    Be more clear please. There is few IdentityServer stuffs. Do I need to create this class in one of the projects? If IDS means IdentityServer, which is not a project

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    hi

    Add this to website.

  • User Avatar
    0
    christophe.baille created

    I updated the class in a new file into HttpApi.Host and all works well now thanks.

    Do you know when it will be fixed on the Framework? Next release?

    Did you refund me the ticket yet as since the beginning the issue is from ABP.IO side?

    Thanks

  • User Avatar
    0
    maliming created
    Support Team Fullstack Developer

    It will be fixed in 4.4.1.

    Ticket refunded. : )

  • User Avatar
    0
    christophe.baille created

    Thanks a lot.

    I close the ticket then

Made with ❤️ on ABP v8.2.0-preview Updated on March 25, 2024, 15:11