Open Closed

Please, fix once and for all the wrong recursive folder exploration made by ABP Suite ! #3797

User avatar
FrancoisLabelle created
  • ABP Framework version: v5.3.4, ABP Suite
  • Steps to reproduce the issue:"
  1. Start abp-suite
  2. Add an existing solution, eg. C:\Sources\ABigProject\ThBigSolution.sln
  3. Return to the main screen
  4. Click on the arrow beside the version number of the solution (for the solution just added)
  5. Click on Update NPM packages...

For an unknown reason, there is a recursive search for files/folders that goes OUT of the expected selected solution folder...

I understand that searching subfolders below is just normal... (E.g. C:\Sources\MyMainProject* )

But, how could you go one folder UP and do a recursive search OUTSIDE of the selected one ?!?!?! ( E.g. C:\Sources* !!!!) It makes no sense at all !!! How can this be a good idea ? You will ending up updating other projects that no one asked you to update (or never figured it will) !!! Let's image how many updates will be done if someone, like me, has unziped all the samples projects, downloaded all modules source code, has made a lot of "test projects" as proof of concepts, has made backup of the main project, etc !!!

I have this issue since a long time... That is not a new bug. can't understand how no one has complained about it yet. That should have been noticed and fixed a long time ago !

That's a major issue. Please, make sure this is fixed soon and that will never occur again.

After waiting almost an hour... a message is displaying "The xxx solutions is updated !" Well, that is not true... because ALL solutions are updated.


4 Answer(s)
  • User Avatar
    yekalkan created
    Support Team Fullstack Developer

    Hi @FrancoisLabelle,

    We have made adjustments about that in v6.0.0 milestone. The problem will be fixed.

    Alternatively you can use abp update command:

  • User Avatar
    alper created
    Support Team Director

    closing the issue... if you encounter the problem again in the new version you can always re-open this.

  • User Avatar
    FrancoisLabelle created

    The version 6.6.0-rtc.5 is not really better. Well, not yet fully tested I guess...

    Packages update is working from the main page. But, when you click on solution and goes the the "crud page"...

    1. The Update menu is not the same. We miss the "switch to xxx " menu items.
    2. If you launch the "update all packages", you will get the famous "An internal error has occurred"

    The underlying error is path related. Let's say you have started abp-suite in a command prompt while being in a folder named C:\MyFolder, then, the error message will tell this: ERR] Could not find a part of the path 'c:\MyFolder\MySolutionName'. System.IO.DirectoryNotFoundException: Could not find a part of the path 'c:\MyFolder\MySolutionName'.

    Again, it makes no sense !?!? Why appending the "startup folder" of abp-suite to the selected solution name... when you already have the full path of the solution selected (in my case, C:\Sources\MySolutionName). ?!?!?

    Also, with 5.3.4 and 6 rc5, I recurrently have this error

    ERR] The file 'C:\Users\flabelle\AppData\Local\Temp\Suite.dll' already exists. System.IO.IOException: The file 'C:\Users\flabelle\AppData\Local\Temp\Suite.dll' already exists. at System.IO.FileSystem.CopyFile(String sourceFullPath, String destFullPath, Boolean overwrite) at System.IO.File.Copy(String sourceFileName, String destFileName, Boolean overwrite) at System.IO.File.Copy(String sourceFileName, String destFileName) at Volo.Abp.Suite.Areas.AbpSuite.CrudPageGenerator.Services.SuiteAssemblyService.B6vUUTF0OS(String )

    ... Then I close Abp-suite, delete the suite.dll in the temp folder, and restart from scratch. Annoying !

  • User Avatar
    FrancoisLabelle created


    Version 6.0.0 (final release) is OK... well... after a second try. I have updated CLI to 6.0.0 and Suite to 6.0.0, started it... and I got errors while trying to update packages.

    2022-10-06 11:08:11.223 -04:00 [ERR] Value cannot be null. (Parameter 'source') System.ArgumentNullException: Value cannot be null. (Parameter 'source') at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument) at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable1 source, Func2 predicate, Boolean& found) at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable1 source, Func2 predicate) at Volo.Abp.Cli.ProjectModification.VoloNugetPackagesVersionUpdater.GetLatestVersionFromMyGet(String packageId) in D:\ci\Jenkins\workspace\abp-commercial-release

    I closed everything... deleted the suite.dll in my %temp% folder (because I had issues with this previously)... started ABP Suite and proceed to update... Then, everything went well, fast, and without any update of unwanted folders...


Made with ❤️ on ABP v8.2.0-preview Updated on March 25, 2024, 15:11