Hi @gizem
Did you able to test?
Hi @alper my database is on the cloud and services are working on-premises so if there is too much round trip that may cause too much latency. And for 900 records 4.5 second is not also a good time. Is it possible to change fetching all records to fetching only current page records. And also could you please check if there is a loop for user or tenant info fetch?
Hi @maliming
Any news about this problem?
Sent via mail
Hi @maliming
Your code (Pull Request) works on Abp 7.2, our project is Abp 5.3.3 so we had to change some codes. I changed IdentityUserRepository variable's type from IIdentityUserRepository to IRepository<IdentityUser>.
And did a second change on using IdentityUserRepository like below:
//var users = await IdentityUserRepository.GetListByIdsAsync(userGroup.Select(x => x.TargetUserId));
//changed above code like below
var users = (await IdentityUserRepository.GetQueryableAsync())
.Where(p => userGroup.Select(p => p.TargetUserId).Contains(p.Id)).ToList();
In this scenario operation time gets to 15 seconds from 30 seconds.
We made a performance improvement on your code like below and operation time is reduced to 10 seconds from 15 seconds with this change below (increased round trip on your code):
List<IdentityUser> allUsers = new(); //added
using (dataFilter.Disable()) //added
{
allUsers = (await IdentityUserRepository.GetQueryableAsync()) //added
.Where(p => allLinkUsers.Select(p => p.TargetUserId).Contains(p.Id)).ToList(); //added
} //added
foreach (var userGroup in allLinkUsers.GroupBy(x => x.TargetTenantId))
{
var tenantId = userGroup.Key;
TenantConfiguration tenant = null;
if (tenantId.HasValue)
{
tenant = await TenantStore.FindAsync(tenantId.Value);
}
using (CurrentTenant.Change(tenantId))
{
//var users = await IdentityUserRepository.GetListByIdsAsync(userGroup.Select(x => x.TargetUserId)); //commented
//changed above line like below line
var users = allUsers.Where(p => userGroup.Select(p => p.TargetUserId).Contains(p.Id)).ToList(); //added
foreach (var user in users)
{
userDto.Add(new LinkUserDto
{
TargetUserId = user.Id,
TargetUserName = user.UserName,
TargetTenantId = tenant?.Id,
TargetTenantName = tenant?.Name,
DirectlyLinked = userGroup.FirstOrDefault(x => x.TargetUserId == user.Id)?.DirectlyLinked ?? false
});
}
}
}
Note We reduced operation time to 10 seconds and nearly all the time is used by below code line. We inspected source of IdentityLinkUserManager.GetListAsync() method from github and this method makes too much round trips:
var linkUsers = await IdentityLinkUserManager.GetListAsync(new IdentityLinkUserInfo(currentUserId, currentTenantId), includeIndirect: true);
Hi Anjali_Musmade,
You can find below:
{
"Settings": {
"Abp.Mailing.DefaultFromAddress": "noreply.information.myprojectname@mydomain.com",
"Abp.Mailing.DefaultFromDisplayName": "MyCompany myprojectname"
},
"App": {
"SelfUrl": "https://myprojectname-api.mydomain.com",
"AngularUrl": "https://myprojectname.mydomain.com",
"CorsOrigins": "https://*.myprojectname.com,http://localhost:4200,https://myprojectname.mydomain.com",
"RedirectAllowedUrls": "https://myprojectname.mydomain.com",
"DisablePII": "true",
"HealthCheckUrl": "/health-status"
},
"ConnectionStrings": {
"Default": "Host=mydb.mydomain.com;Port=5432;Database=myprojectname;User ID=myprojectname_app;Password=*******;"
},
"AuthServer": {
"Authority": "https://myprojectname-api.mydomain.com",
"RequireHttpsMetadata": "true",
"SwaggerClientId": "myprojectname_Swagger"
},
"StringEncryption": {
"DefaultPassPhrase": "*************"
}
}
Hi @maliming
We are trying to go live and this mistake preventing us. We need urgent support.
Can you please share a demo or a sample code?
I will also try your logging code and share result but i tried a method and results are like below. Can you please check below log.
Valid URL: https://myproject-api.ekol.com/api/account-admin/settings/two-factor Invalid URL (HTTP404): https://myproject-api.ekol.com/swagger/v1/api/account-admin/settings/two-factor
2023-08-28 16:39:50.203 +03:00 [INF] Request:
Protocol: HTTP/1.1
Method: PUT
Scheme: https
PathBase:
Path: /swagger/v1/api/account-admin/settings/two-factor
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Connection: keep-alive
Host: myproject-api.ekol.com
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36
Accept-Encoding: gzip,deflate,br
Content-Type: application/json
Cookie: [Redacted]
Content-Length: 210
X-Real-IP: [Redacted]
X-Forwarded-For: [Redacted]
X-Forwarded-Proto: [Redacted]
2023-08-28 16:39:50.206 +03:00 [ERR] An unhandled exception has occurred while executing the request.
System.UriFormatException: Invalid URI: The hostname could not be parsed.
at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions)
at System.Uri..ctor(String uriString, UriKind uriKind)
at OpenIddict.Validation.AspNetCore.OpenIddictValidationAspNetCoreHandlers.ResolveRequestUri.HandleAsync(ProcessRequestContext context)
at OpenIddict.Validation.OpenIddictValidationDispatcher.DispatchAsync[TContext](TContext context)
at OpenIddict.Validation.OpenIddictValidationDispatcher.DispatchAsync[TContext](TContext context)
at OpenIddict.Validation.AspNetCore.OpenIddictValidationAspNetCoreHandler.HandleRequestAsync()
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
at Volo.Abp.AspNetCore.Security.AbpSecurityHeadersMiddleware.InvokeAsync(HttpContext context, RequestDelegate next)
at Microsoft.AspNetCore.Builder.UseMiddlewareExtensions.<>c__DisplayClass6_1.<<UseMiddlewareInterface>b__1>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.AspNetCore.HttpLogging.HttpLoggingMiddleware.InvokeInternal(HttpContext context)
at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl.<Invoke>g__Awaited|8_0(ExceptionHandlerMiddlewareImpl middleware, HttpContext context, Task task)
We have deployment scripts nearly same (except server name and build directory). If you share email address, i can send build scripts for both environment.