Unable to login with Microsoft external provider after email registration because email registration process is repeated #543

10 उत्तर (ओं)

• 

  0

  michael.sudnik बनाया था 3 years ago

  Maybe the problem is here and the AbpClaimTypes.Email is not available?

  https://github.com/abpframework/abp/blob/de7d480af49b5292716a3d130c4602da202388c2/modules/account/src/Volo.Abp.Account.Web/Pages/Account/Login.cshtml.cs#L226

  But, the "Register Email" page does seem to populate it ok.

  बचाना रद्द करना
• 

  0

  michael.sudnik बनाया था 3 years ago

  I still have not figured out what is going on. I have tried implementing a custom AbpSignInManager and can see that the ExternalLoginSignInAsync method result has all properties set to false (Failed). The method is also not hitting the PreSignInCheck, which implies that it is failing in the UserManager.FindByLoginAsync(loginProvider, providerKey) method. After investigating what this does, it is suspicious that the user in the database does not have any logins associated with it. I am using MongoDB and am wondering if the logins are not being persisted to the database. Also - the IsExternal property is set to false, which does not seem right. I will keep investigating until someone else can offer any help. Thanks.

  बचाना रद्द करना
• 

  0

  maliming बनाया था 3 years ago

  सहायता दल Fullstack Developer

  hi

  Can you share your external login code and provide a test Microsoft account? liming.ma@volosoft.com

  बचाना रद्द करना
• 

  0

  michael.sudnik बनाया था 3 years ago

  I have now created a brand new v4.0.0-rc3 version and made only a single modification to the code.

  .AddMicrosoftAccount(MicrosoftAccountDefaults.AuthenticationScheme, "Company", options =>
                  {
                      options.AuthorizationEndpoint = "https://login.microsoftonline.com/[###MY TENENT ID###]/oauth2/v2.0/authorize";
                      options.TokenEndpoint = "https://login.microsoftonline.com/[##MY TENENT ID###]/oauth2/v2.0/token";
                  })
  

  The problem occurs when running locally, without publishing to azure.

  The inclusion of the following code, fixes the problem for some reason:

   [Dependency(ReplaceServices = true)]
      [ExposeServices(typeof(RegisterModel))]
      public class CustomRegisterModel : RegisterModel
      {
          protected override async Task RegisterExternalUserAsync(ExternalLoginInfo externalLoginInfo, string emailAddress)
          {
              var user = new IdentityUser(GuidGenerator.Create(), emailAddress, emailAddress, CurrentTenant.Id);
  
              (await UserManager.CreateAsync(user)).CheckErrors();
              (await UserManager.AddDefaultRolesAsync(user)).CheckErrors();
  
              var userLoginAlreadyExists = user.Logins.Any(x =>
                  x.TenantId == user.TenantId &&
                  x.LoginProvider == externalLoginInfo.LoginProvider &&
                  x.ProviderKey == externalLoginInfo.ProviderKey);
  
              if (!userLoginAlreadyExists)
              {
                  (await UserManager.AddLoginAsync(user, new UserLoginInfo(
                      externalLoginInfo.LoginProvider,
                      externalLoginInfo.ProviderKey,
                      externalLoginInfo.ProviderDisplayName
                  ))).CheckErrors();
              }
  
              await SignInManager.SignInAsync(user, isPersistent: true);
          }
      }
  

  बचाना रद्द करना
• 

  0

  maliming बनाया था 3 years ago

  सहायता दल Fullstack Developer

  hi @michael.sudnik

  Can you share the ClientId and ClientSecret with me? so that I can test it locally.

  liming.ma@volosoft.com

  बचाना रद्द करना
• 

  0

  maliming बनाया था 3 years ago

  सहायता दल Fullstack Developer

  hi

  I received the mail, I will check, thank you

  बचाना रद्द करना
• 

  0

  maliming बनाया था 3 years ago

  सहायता दल Fullstack Developer

  hi

  I create a mvc project using 4.0.0-rc.3, When I register with my email, it will automatically log in when I log in again.

  ! 4.0.0 has not yet released the official version, RC is for testing only.
  
  dotnet tool uninstall --global Volo.Abp.Cli && dotnet tool install --global Volo.Abp.Cli --version 4.0.0-rc.3
  abp new MyApp -t app-pro -u mvc --mobile none --database-provider ef --csf --preview
  

  

  

  

  बचाना रद्द करना
• 

  0

  michael.sudnik बनाया था 3 years ago

  Hi,

  When i perform the same steps as you to create a new solution (using EF), I can confirm that it works and I can logout and log back in again repeatedly without any problems.

  However, when I create a new app using the MongoDB database provider, I then see the incorrect behaviour.

  abp new MyApp -t app-pro -u mvc --mobile none --database-provider mongodb --csf --preview
  

  Thanks for looking into it.

  बचाना रद्द करना
• 

  0

  maliming बनाया था 3 years ago

  सहायता दल Fullstack Developer

  hi

  It seems there is a problem with mongodb, I will check it. Thank you

  बचाना रद्द करना
• 

  0

  maliming बनाया था 3 years ago

  सहायता दल Fullstack Developer

  hi @michael.sudnik

  The below code is the patch. I will fix this in 4.0.

  

  using System.Linq;
  using System.Threading.Tasks;
  using Microsoft.AspNetCore.Identity;
  using Volo.Abp.Account;
  using Volo.Abp.Account.Public.Web.Pages.Account;
  using Volo.Abp.DependencyInjection;
  using IdentityUser = Volo.Abp.Identity.IdentityUser;
  
  namespace MyApp.Web
  {
        [ExposeServices(typeof(MyRegisterModel), typeof(RegisterModel))]
        public class MyRegisterModel : RegisterModel
        {
              protected override async Task RegisterExternalUserAsync(ExternalLoginInfo externalLoginInfo, string emailAddress)
              {
                    var user = new IdentityUser(GuidGenerator.Create(), emailAddress, emailAddress, CurrentTenant.Id);
  
                    (await UserManager.CreateAsync(user)).CheckErrors();
                    (await UserManager.AddDefaultRolesAsync(user)).CheckErrors();
  
                    if (!user.EmailConfirmed)
                    {
                          await AccountAppService.SendEmailConfirmationTokenAsync(
                                new SendEmailConfirmationTokenDto
                                {
                                      AppName = "MVC",
                                      Email = emailAddress,
                                      ReturnUrl = ReturnUrl,
                                      ReturnUrlHash = ReturnUrlHash
                                }
                          );
                    }
  
                    var userLoginAlreadyExists = user.Logins.Any(x =>
                          x.TenantId == user.TenantId &&
                          x.LoginProvider == externalLoginInfo.LoginProvider &&
                          x.ProviderKey == externalLoginInfo.ProviderKey);
  
                    if (!userLoginAlreadyExists)
                    {
                          user.AddLogin(new UserLoginInfo(
                                      externalLoginInfo.LoginProvider,
                                      externalLoginInfo.ProviderKey,
                                      externalLoginInfo.ProviderDisplayName
                                )
                          );
  
                          (await UserManager.UpdateAsync(user)).CheckErrors();
                    }
  
                    await SignInManager.SignInAsync(user, isPersistent: true);
              }
        }
  }
  
  

  बचाना रद्द करना