Stress Test And Bottlenecks #5990

7 Answer(s)

• 

  0

  liangshiwei created 6 months ago

  Support Team Fullstack Developer

  Since my text templates doesn't use any localization is it possible to use VirtualFileTemplateContentContributor instead? Of course I can add another ITemplateContentContributor. I just wonder if there is any other way to avoid trying the last contributor and only use VirtualFileTemplateContentContributor, since I don't want the code to go to redis cache or database at all. All I need is to get the template from virtual file system and replace it with the model.

  You can remove DatabaseTemplateContentContributor from the AbpTextTemplatingOptions.

  For example:

  public override void ConfigureServices(ServiceConfigurationContext context)
  {
      Configure<AbpTextTemplatingOptions>(options =>
      {
          options.ContentContributors.RemoveAll(x => x == typeof(DatabaseTemplateContentContributor));
      });
  }
  

  Save Cancel
• 

  0

  liangshiwei created 6 months ago

  Support Team Fullstack Developer

  Also I wonder what is happening in this setup, Is the bottleneck happening from the redis cache or from the database connection? At first thought, I assume it is sth going on with Redis Cache,

  This looks like a bottleneck for redis.

  Save Cancel
• 

  0

  cangunaydin created 6 months ago

  Hello, Thanks for the answer.

  public override void ConfigureServices(ServiceConfigurationContext context) { Configure(options => { options.ContentContributors.RemoveAll(x => x == typeof(DatabaseTemplateContentContributor)); }); }

  I only want to remove this option when I use the specific templates, for the other templates like emailing, i think i need this. I don't think there is an option for that right now?

  To overcome the problem for now i am adding prefix to the name of the templates that I want to exclude, and added another template content contributor

  public class MyVirtualFileTemplateContentContributor : VirtualFileTemplateContentContributor, ITransientDependency
  {
      private readonly ILocalizedTemplateContentReaderFactory _localizedTemplateContentReaderFactory;
  
      public MyVirtualFileTemplateContentContributor(
          ILocalizedTemplateContentReaderFactory localizedTemplateContentReaderFactory) : base(
          localizedTemplateContentReaderFactory)
      {
          _localizedTemplateContentReaderFactory = localizedTemplateContentReaderFactory;
      }
  
      public override async Task<string> GetOrNullAsync(TemplateContentContributorContext context)
      {
          if (!context.TemplateDefinition.Name.Contains(MyTemplateDefinitionProvider.TemplateGroup))
          {
              return null;
          }
  
          var localizedReader = await _localizedTemplateContentReaderFactory
              .CreateAsync(context.TemplateDefinition);
  
          return localizedReader.GetContentOrNull(
              null
          );
      }
  }
  

  so i fixed the problem in that way.

  For the second question, I am not so sure about if it is a redis problem. I do not understand why redis should have a bottleneck with 2000 requests. Also I am not sure why the redis trying to get the value of AbpExceptionHandling_en from Volo.Abp.LanguageManagement.Texts

  redis-command = HMGET c:Volo.Abp.LanguageManagement.Texts,k:Adzup:AbpExceptionHandling_en

  With DatabaseTemplateContentContributor, the code will go through and tries to get the value with localization from the repository, so every request that hits the backend will try to go to db first

  

  here you can see that the code will check the db and since it is a static store it will return null. And this has been tried with localization "en" and couldn't find it. Next try will be with null, and in that case the same thing will happen from dbcontributor, if you have en-En culture it will do 3 times

  

  so it will look twice to database at least. In this process i was thinking if every request is creating 2 different connection to db it takes longer time to get the result or maybe sth else.Then it is triggering the redis overload cause it seems like when exception is happening Abp is trying to find some localization parameters from redis cache.

  At the end of this story, I fixed my problem by not going to db or redis at all, with implementing ITemplateContributor. Still not sure how much clients can my app serve if there is a need to go to db for crud operations or just for querying purpose. Should i create redis cluster? should i do postgres sharding or just do load balancing? I am so confused.

  Is there any benchmark that has been done with abp template for stress testing? I don't want to deploy the app and having surprises.

  Since it is gonna be iot devices that will connect to server it can increase the load very much. I need to find the sweet spot for 1 instance so i can do the decisions for sharding and clusters. I am not expecting more than 10 000 devices inside the system. So i was expecting to handle that much load with 1 instance.

  Save Cancel
• 

  0

  liangshiwei created 6 months ago

  Support Team Fullstack Developer

  I only want to remove this option when I use the specific templates, for the other templates like emailing, i think i need this. I don't think there is an option for that right now?

  You can replace the DatabaseTemplateContentContributor with your own. for example:

  [ExposeServices(typeof(MyDatabaseTemplateContentContributor), typeof(ITemplateContentContributor))]
  public class MyDatabaseTemplateContentContributor : DatabaseTemplateContentContributor
  {
      public override async Task<string> GetOrNullAsync(TemplateContentContributorContext context)
      {
          if(context.TemplateDefinition.Name == "MyTemplate.....")
          {
             return null; // skip
          }
          
          return await Cache.GetOrAddAsync(
              new TemplateContentCacheKey(context.TemplateDefinition.Name, context.Culture),
              async () => await GetTemplateContentFromDbOrNullAsync(context),
              () => new DistributedCacheEntryOptions
              {
                  SlidingExpiration = Options.MinimumCacheDuration
              }
          );
      }
  }
  
  public override void ConfigureServices(ServiceConfigurationContext context)
  {
      Configure<AbpTextTemplatingOptions>(options =>
      {
          options.ContentContributors.RemoveAll(x => x == typeof(DatabaseTemplateContentContributor));
      });
  }
  

  To overcome the problem for now i am adding prefix to the name of the templates that I want to exclude, and added another template content contributor

  That's fine.

  here you can see that the code will check the db and since it is a static store it will return null. And this has been tried with localization "en" and couldn't find it. Next try will be with null, and in that case the same thing will happen from dbcontributor, if you have en-En culture it will do 3 times

  Because the template system supports multiple languages, if the current language template does not exist, it will try to regress to the default language. this is by design.

  You can override the default implementation if you want.

  Is there any benchmark that has been done with abp template for stress testing? I don't want to deploy the app and having surprises. Since it is gonna be iot devices that will connect to server it can increase the load very much. I need to find the sweet spot for 1 instance so i can do the decisions for sharding and clusters. I am not expecting more than 10 000 devices inside the system. So i was expecting to handle that much load with 1 instance.

  No, we didn't do such a test. I think you must know the 80-20 rule, you can optimize for specific templates, such as using memory cache, which will greatly improve performance.

  Save Cancel
• 

  0

  cangunaydin created 6 months ago

  Hello, thanks for the answers. I don't know about the 80-20 rule. You mean pareto principle? I already use the caching, my problem is about finding the limit of how much devices i can serve. If i can find it then i can plan it accordingly, by using clusters or with other solutions. In abp system, I have trouble understanding the cause, there are bunch of things going on the background for an http request which comes from middleware, by logging or opening a transactional unitofwork writing audit logs to database and etc. That's fine and i am not complaining about it. But it is difficult to read the errors as i show it on my past answer.

  For ex i can not understand why abp is trying to get the Volo.Abp.LanguageManagement.Texts,k:Adzup:AbpExceptionHandling_en text from redis cache? redis-command = HMGET c:Volo.Abp.LanguageManagement.Texts,k:Adzup:AbpExceptionHandling_en

  is this coming from after another exception or it is because it can not reach the redis server since it is bloated? Since this is kind of abstract discussion, I think i will move on and see with my new code how many problems i am gonna get.

  I really appreciate the answers though, thank you.

  Save Cancel
• 

  0

  liangshiwei created 6 months ago

  Support Team Fullstack Developer

  Hi,

  For ex i can not understand why abp is trying to get the Volo.Abp.LanguageManagement.Texts,k:Adzup:AbpExceptionHandling_en text from redis cache?

  The LanguageManagement module provides the ability to dynamic language text, but we don't want to query the database every time, so we use cache to improve performance.

  Because ABP framework provides a lot of infrastructure: multilingual, multi-tenant, auditing, etc. Of course, they will affect performance, but it is enough for regular web applications.

  my problem is about finding the limit of how much devices i can serve. If i can find it then i can plan it accordingly, by using clusters or with other solutions

  Sorry, I can't give an answer. You can test it and find the point that affects performance. I will try to help you to improve it.

  Save Cancel
• 

  0

  cangunaydin created 6 months ago

  Thanks a lot closing the ticket for now, if i find sth i can create a new ticket. Thanks for the answers.

  Save Cancel