Unit of work not performing rollback on exception in appservice #939

9 Answer(s)

• 

  0

  liangshiwei created 3 years ago

  Support Team Fullstack Developer

  I can't reproduce your problem.

  Can you provide a project to reproduce? thanks.

  

  Save Cancel
• 

  0

  pontus created 3 years ago

  https://github.com/PontusLjungdahl/abpbook2

  Save Cancel
• 

  0

  Moyaoxiang created 3 years ago

  Hi pontus, You only need to delete the app.UseUnitOfWork(); statement in BookStoreHttpApiHostModule. the reason: ABP will use AbpUowActionFilter to process work units by default. After adding middleware, it will use AbpUnitOfWorkMiddleware to create work units first. In AbpUowActionFilter, the original Exception was swallowed, and AbpUnitOfWorkMiddleware considered that no exception occurred, so the data was submitted to the database. I think this is a bug.

  Save Cancel
• 

  0

  pontus created 3 years ago

  Thank you.

  Save Cancel
• 

  0

  liangshiwei created 3 years ago

  Support Team Fullstack Developer

  Hi,

  https://github.com/PontusLjungdahl/abpbook2

  Please remove the repo on Github, because the source code has your linence key, it's not safe for you.

  Save Cancel
• 

  0

  pontus created 3 years ago

  Hi,

  https://github.com/PontusLjungdahl/abpbook2

  Please remove the repo on Github, because the source code has your linence key, it's not safe for you.

  Thank you, it's removed.

  Save Cancel
• 

  0

  maliming created 3 years ago

  Support Team Fullstack Developer

  https://github.com/abpframework/abp/pull/7804

  Save Cancel
• 

  0

  liangshiwei created 3 years ago

  Support Team Fullstack Developer

  HI,

  We will fix it by https://github.com/abpframework/abp/pull/7804

  For now , you can try:

  public class MyAbpUowActionFilter : IAsyncActionFilter, ITransientDependency
  {
      public async Task OnActionExecutionAsync(ActionExecutingContext context, ActionExecutionDelegate next)
      {
          if (!context.ActionDescriptor.IsControllerAction())
          {
              await next();
              return;
          }
  
          var methodInfo = context.ActionDescriptor.GetMethodInfo();
          var unitOfWorkAttr = UnitOfWorkHelper.GetUnitOfWorkAttributeOrNull(methodInfo);
  
          context.HttpContext.Items["_AbpActionInfo"] = new AbpActionInfoInHttpContext
          {
              IsObjectResult = context.ActionDescriptor.HasObjectResult()
          };
  
          if (unitOfWorkAttr?.IsDisabled == true)
          {
              await next();
              return;
          }
  
          var options = CreateOptions(context, unitOfWorkAttr);
  
          var unitOfWorkManager = context.HttpContext.RequestServices.GetRequiredService<IUnitOfWorkManager>();
  
          //Trying to begin a reserved UOW by AbpUnitOfWorkMiddleware
          if (unitOfWorkManager.TryBeginReserved(UnitOfWork.UnitOfWorkReservationName, options))
          {
              var result = await next();
              if (!Succeed(result))
              {
                  await RollbackAsync(context, unitOfWorkManager);
              }
  
              return;
          }
  
          //Begin a new, independent unit of work
          using (var uow = unitOfWorkManager.Begin(options))
          {
              var result = await next();
              if (Succeed(result))
              {
                  await uow.CompleteAsync(context.HttpContext.RequestAborted);
              }
              else
              {
                  await uow.RollbackAsync(context.HttpContext.RequestAborted);
              }
          }
      }
  
      private AbpUnitOfWorkOptions CreateOptions(ActionExecutingContext context,
          UnitOfWorkAttribute unitOfWorkAttribute)
      {
          var options = new AbpUnitOfWorkOptions();
  
          unitOfWorkAttribute?.SetOptions(options);
  
          if (unitOfWorkAttribute?.IsTransactional == null)
          {
              var abpUnitOfWorkDefaultOptions =
                  context.HttpContext.RequestServices.GetRequiredService<IOptions<AbpUnitOfWorkDefaultOptions>>().Value;
              options.IsTransactional = abpUnitOfWorkDefaultOptions.CalculateIsTransactional(
                  autoValue: !string.Equals(context.HttpContext.Request.Method, HttpMethod.Get.Method,
                      StringComparison.OrdinalIgnoreCase)
              );
          }
  
          return options;
      }
  
      private async Task RollbackAsync(ActionExecutingContext context, IUnitOfWorkManager unitOfWorkManager)
      {
          var currentUow = unitOfWorkManager.Current;
          if (currentUow != null)
          {
              await currentUow.RollbackAsync(context.HttpContext.RequestAborted);
          }
      }
  
      private static bool Succeed(ActionExecutedContext result)
      {
          return result.Exception == null || result.ExceptionHandled;
      }
  }
  

  Configure<MvcOptions>(options =>
  {
      options.Filters.RemoveAll(x => x.GetType() == typeof(AbpUowActionFilter));
      options.Filters.Add<MyAbpUowActionFilter>();
  });
  

  AbpUowPageFilter also.

  Save Cancel
• 

  0

  ServiceBot created 2 years ago

  Support Team Automatic process manager

  This question has been automatically marked as stale because it has not had recent activity.

  Save Cancel