⚠️ Bugs & Issues v7.4.x ⚠️ #5642

0

rashed created 8 months ago

**I think this is not logic **

adding not existing clients to your database is very confusing for deployment team

for example what is the benfite of adding --mobile none -u angular in generation command then you found MVC and Mobile clientIds in your database !!!

0

maliming created 8 months ago

Support Team Fullstack Developer

Thanks, I will create a internal issue for thsi.

0

rashed created 8 months ago

Failed to login from public site

run this command to create a project

abp new MyProject -t app-pro -u angular --preview -v 7.4.0-rc.2 -csf --theme lepton-x --skip-cache --with-public-website --separate-auth-server -dbms SqlServer --separate-auth-server

Then run all web projects and try to login from public site , I got this error

note: I cleard the cache and remove all cookies many times but still same error

0

rashed created 8 months ago

Generated public site

I notice some diffreneces between public site genrated when using angular template and mvc template in tiered architecture and separate auth server although in both cases the public site created as MVC project

Do you mean that ? why you don't use the same template for public site

I use these 2 commands

abp new MyProject -t app-pro -u angular --preview -v 7.4.0-rc.2 -csf --theme lepton-x --skip-cache --with-public-website --separate-auth-server -dbms SqlServer --separate-auth-server

abp new MyProject -t app-pro -u mvc --tiered --preview -v 7.4.0-rc.2 -csf --theme lepton-x --skip-cache --with-public-website --separate-auth-server -dbms SqlServer -cs --separate-auth-server

then I opened public site project and found these diffrences in angular case

no reCaptcha package
no BackgroundWorkers

options.UsePkce = true; only in angular case

0

maliming created 8 months ago

Support Team Fullstack Developer

hi

Is this endpoint success? you can open it in your browser.

0

rashed created 8 months ago

hi

Is this endpoint success? you can open it in your browser.

Hi

no it's not accessiable,

looks like the authority url generated in public web app is diffrent than the one generated in api web app

note: angular app working without issues

0

maliming created 8 months ago

Support Team Fullstack Developer

Thanks we will confirm the problem.

0

maliming created 8 months ago

Support Team Fullstack Developer

hi

You can use --separate-identity-server, we will be compatible in next rc.

new MyProject -t app-pro -u angular --preview -v 7.4.0-rc.2 -csf --theme lepton-x --skip-cache --with-public-website --separate-identity-server -dbms SqlServer --separate-identity-server

0

rashed created 8 months ago

hi

You can use --separate-identity-server, we will be compatible in next rc.

new MyProject -t app-pro -u angular --preview -v 7.4.0-rc.2 -csf --theme lepton-x --skip-cache --with-public-website --separate-identity-server -dbms SqlServer --separate-identity-server

Please note I already use it in my command, you set it 2 times, actually this was not my issue

0

maliming created 8 months ago

Support Team Fullstack Developer

Use --separate-identity-server and try again, Thanks.

https://github.com/abpframework/abp/pull/17519

0

rafael.gonzales created 8 months ago

There is an issue with the version 7.4 rc-3. I have an issue with the following packages that couldn't be restored with this version

Unable to find package Volo.CmsKit.Pro.Common.Web. No packages exist with this id in source(s): ABP Commercial NuGet Source, C:\Program Files\dotnet\library-packs, C:\Program Files\dotnet\sdk\7.0.307\Sdks\Microsoft.NET.Sdk.Web\library-packs, Microsoft Visual Studio Offline Packages, nuget.org

0

EngincanV created 8 months ago

Support Team .NET Developer

There is an issue with the version 7.4 rc-3. I have an issue with the following packages that couldn't be restored with this version

Unable to find package Volo.CmsKit.Pro.Common.Web. No packages exist with this id in source(s): ABP Commercial NuGet Source, C:\Program Files\dotnet\library-packs, C:\Program Files\dotnet\sdk\7.0.307\Sdks\Microsoft.NET.Sdk.Web\library-packs, Microsoft Visual Studio Offline Packages, nuget.org

Hi, thanks for reporting. We will fix the problem and publish the packages asap.

0

EngincanV created 8 months ago

Support Team .NET Developer

There is an issue with the version 7.4 rc-3. I have an issue with the following packages that couldn't be restored with this version

Unable to find package Volo.CmsKit.Pro.Common.Web. No packages exist with this id in source(s): ABP Commercial NuGet Source, C:\Program Files\dotnet\library-packs, C:\Program Files\dotnet\sdk\7.0.307\Sdks\Microsoft.NET.Sdk.Web\library-packs, Microsoft Visual Studio Offline Packages, nuget.org

We have published the missing packages, please try again. (You might want to clear your Nuget cache if the package cannot be found on your first try.)

0

rafael.gonzales created 7 months ago

Hi again, this is your friend Rafael :)

In this template, can we replace the #pragma warning disable CS8618 for a null forgiven or required operator approach?

0

rafael.gonzales created 7 months ago

Also, I noticed that this template lacks a couple of "?" in some nullable string parameters.

0

rafael.gonzales created 7 months ago

There are a couple of missing "?" in this template too

In the same template, this "filterText" should be nullable too

0

rafael.gonzales created 8 months ago

ABP Suite still generates EntityManager generated class with methods without null validation checking

In this example the GeoManager class is generating a Create Method with a parameter of type "string codigoInei = null".

It should be "string? codigoInei = null". This complicates us if I want to re-generate the ABP Suite. I will need to fix everytime.

0

rafael.gonzales created 8 months ago

This situation happen also in the Geo.Extended.cs class in the Domain Project

The constructor generated in the base class as the extended class are generated properties with the same problem (for nullable properties)

"string codigoInei = null"

instead of "string? codigoInei = null"

0

rafael.gonzales created 8 months ago

There is another issue in the generated EfCoreEntityRepository.cs class

The issue corresponds to the **FindAsync **method inside the **EfCoreRepository ** class

There seems to be a problem between the nullable-enabled project and the non-enabled nullable project (EntityFramework Project). One method returns a nullable type while the other expects a non-nullable return value.

This is a critical error for the new version.

3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match member "Task<Ubigeo?> IRepository<Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" implemented implicitly.
3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match the implicitly implemented member "Task<Ubigeo?> IReadOnlyBasicRepository<Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))".
3>------- Finished building project: D.EntitemoyFrameworkCore. Succeeded: False. Errors: 2. Warnings: 0

1

rafael.gonzales created 8 months ago

There is another issue in the generated EfCoreEntityRepository.cs class

The issue corresponds to the **FindAsync **method inside the **EfCoreRepository ** class

There seems to be a problem between the nullable-enabled project and the non-enabled nullable project (EntityFramework Project). One method returns a nullable type while the other expects a non-nullable return value.

This is a critical error for the new version.

3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match member "Task<Ubigeo?> IRepository<Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" implemented implicitly. 
3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match the implicitly implemented member "Task<Ubigeo?> IReadOnlyBasicRepository<Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))". 
3>------- Finished building project: D.EntitemoyFrameworkCore. Succeeded: False. Errors: 2. Warnings: 0

The solution for this is the following.

In **EfCoreRepository.cs **

Replace this code:

public async override Task&lt;TEntity&gt; FindAsync(
    Expression&lt;Func&lt;TEntity, bool&gt;> predicate,
    bool includeDetails = true,
    CancellationToken cancellationToken = default)
{
    return includeDetails
        ? await (await WithDetailsAsync())
            .Where(predicate)
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken))
        : await (await GetDbSetAsync())
            .Where(predicate)
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken));
}

For this

public async override Task&lt;TEntity?&gt; FindAsync(
    Expression&lt;Func&lt;TEntity, bool&gt;> predicate,
    bool includeDetails = true,
    CancellationToken cancellationToken = default)
{
    return includeDetails
        ? await (await WithDetailsAsync())
            .Where(predicate)
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken))
        : await (await GetDbSetAsync())
            .Where(predicate)
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken));
}

And replace this code:

public virtual async Task&lt;TEntity&gt; FindAsync(TKey id, bool includeDetails = true, CancellationToken cancellationToken = default)
{
    return includeDetails
        ? await (await WithDetailsAsync()).OrderBy(e => e.Id).FirstOrDefaultAsync(e => e.Id.Equals(id), GetCancellationToken(cancellationToken))
        : await (await GetDbSetAsync()).FindAsync(new object[] { id }, GetCancellationToken(cancellationToken));
}

For this one public virtual async Task<TEntity?> FindAsync(TKey id, bool includeDetails = true, CancellationToken cancellationToken = default) { return includeDetails ? await (await WithDetailsAsync()).OrderBy(e => e.Id).FirstOrDefaultAsync(e => e.Id.Equals(id), GetCancellationToken(cancellationToken)) : await (await GetDbSetAsync()).FindAsync(new object[] { id }, GetCancellationToken(cancellationToken)); }

0

rafael.gonzales created 8 months ago

Another observation,

There is no lepton 2.4.0-rc.3, is this normal?

0

EngincanV created 8 months ago

Support Team .NET Developer

Hi again, this is your friend Rafael :)

In this template, can we replace the #pragma warning disable CS8618 for a null forgiven or required operator approach?

Thanks for your suggestion. I will update it.

0

EngincanV created 8 months ago

Support Team .NET Developer

There are a couple of missing "?" in this template too

In the same template, this "filterText" should be nullable too

Thanks for reporting. I have created an issue for it and will fix it asap. BTW, I'm also checking your other findings.

0

byersjus created 7 months ago

There seems to be a bug when adding navigation collections (n:n) via Suite. In my case, I'm adding a navigation to a 'Tool' entity from 'ToolAssemblies' and get the following errors:

Edit: I should note this only occurs when using the 'Customizable code' option during crud page generation.

Error CS7036 There is no argument given that corresponds to the required parameter 'toolRepository' of 'ToolAssemblyManagerBase.ToolAssemblyManagerBase(IToolAssemblyRepository, IRepository<Tool, Guid>)' ToolAssemblyManager.Extended.cs

Error CS7036 There is no argument given that corresponds to the required parameter 'toolRepository' of 'ToolAssembliesAppServiceBase.ToolAssembliesAppServiceBase(IToolAssemblyRepository, ToolAssemblyManager, IDistributedCache<ToolAssemblyExcelDownloadTokenCacheItem, string>, IRepository<Tool, Guid>)' ToolAssembliesAppService.Extended.cs

0

EngincanV created 7 months ago

Support Team .NET Developer

There seems to be a bug when adding navigation collections (n:n) via Suite. In my case, I'm adding a navigation to a 'Tool' entity from 'ToolAssemblies' and get the following errors:

Edit: I should note this only occurs when using the 'Customizable code' option during crud page generation.

Error CS7036 There is no argument given that corresponds to the required parameter 'toolRepository' of 'ToolAssemblyManagerBase.ToolAssemblyManagerBase(IToolAssemblyRepository, IRepository<Tool, Guid>)' ToolAssemblyManager.Extended.cs

Error CS7036 There is no argument given that corresponds to the required parameter 'toolRepository' of 'ToolAssembliesAppServiceBase.ToolAssembliesAppServiceBase(IToolAssemblyRepository, ToolAssemblyManager, IDistributedCache<ToolAssemblyExcelDownloadTokenCacheItem, string>, IRepository<Tool, Guid>)' ToolAssembliesAppService.Extended.cs

Thanks for reporting. Whenever a many-to-many relation is established, it seems we also need to re-generate the ctor for the custom manager and appservice classes. I will create an issue for it and will fix it asap.

67 Answer(s)

Failed to login from public site

Generated public site